Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-430: Add resource_server_scopes resource #600

Merged
merged 1 commit into from
May 25, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR adds a new resource_server_scopes resource to manage 1:many association between resource servers and its scopes.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner May 24, 2023 11:34
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good just consideration of schema property naming for consistency.

@sergiught sergiught force-pushed the feature/DXCDT-430-1-many-scopes branch from 6f7b6a4 to 96c4159 Compare May 24, 2023 16:23
@sergiught sergiught requested a review from willvedd May 24, 2023 16:27
@sergiught sergiught merged commit b2ba802 into main May 25, 2023
@sergiught sergiught deleted the feature/DXCDT-430-1-many-scopes branch May 25, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants