Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-308: Add guide on how to achieve 0 downtime client credential rotation #592

Merged
merged 8 commits into from
May 23, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner May 22, 2023 12:30
@willvedd
Copy link
Contributor

The content is good but how will it be discovered? It needs to have some inbound links so that people can find this content. IMO it makes sense for it to be mentioned in the client docs and in the readme.

Base automatically changed from feature/DXCDT-147-JWT-CA-victory to main May 22, 2023 18:03
@sergiught
Copy link
Contributor Author

Good point, please check f3ca52e (#592)

@codecov-commenter
Copy link

Codecov Report

Merging #592 (f3ca52e) into main (7f2eecc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   86.86%   86.87%           
=======================================
  Files          71       71           
  Lines       11148    11154    +6     
=======================================
+ Hits         9684     9690    +6     
  Misses       1116     1116           
  Partials      348      348           
Impacted Files Coverage Δ
internal/auth0/client/resource.go 97.23% <100.00%> (+0.02%) ⬆️

docs/resources/client.md Outdated Show resolved Hide resolved
@sergiught sergiught requested a review from willvedd May 23, 2023 08:46
@sergiught sergiught merged commit bf352fa into main May 23, 2023
@sergiught sergiught deleted the guide/0-downtime branch May 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants