Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-147: Add new auth0_client_credentials resource with support for JWT CA #588

Merged
merged 6 commits into from
May 22, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented May 19, 2023

🔧 Changes

In this PR we are adding a dedicated auth0_client_credentials resource to manage all things credentials of an auth0_client resource, e.g. authentication method, client secret and client credentials.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the feature/DXCDT-147-JWT-CA-victory branch 3 times, most recently from 38718a9 to 9505baf Compare May 19, 2023 16:51
@sergiught sergiught force-pushed the feature/DXCDT-147-JWT-CA-victory branch from 9505baf to 614f3a1 Compare May 22, 2023 12:20
@sergiught sergiught changed the base branch from main to bump/go-auth0 May 22, 2023 12:21
@sergiught sergiught marked this pull request as ready for review May 22, 2023 12:25
@sergiught sergiught requested a review from a team as a code owner May 22, 2023 12:25
@codecov-commenter
Copy link

Codecov Report

Merging #588 (614f3a1) into bump/go-auth0 (abe01d2) will decrease coverage by 0.38%.
The diff coverage is 78.02%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           bump/go-auth0     #588      +/-   ##
=================================================
- Coverage          87.24%   86.86%   -0.38%     
=================================================
  Files                 70       71       +1     
  Lines              10693    11148     +455     
=================================================
+ Hits                9329     9684     +355     
- Misses              1037     1116      +79     
- Partials             327      348      +21     
Impacted Files Coverage Δ
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/client/resource_credentials.go 77.77% <77.77%> (ø)
internal/auth0/client/resource.go 97.21% <100.00%> (+0.01%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-147-JWT-CA-victory branch from 614f3a1 to 3adf724 Compare May 22, 2023 12:27
Base automatically changed from bump/go-auth0 to main May 22, 2023 18:03
@sergiught sergiught merged commit 7f2eecc into main May 22, 2023
@sergiught sergiught deleted the feature/DXCDT-147-JWT-CA-victory branch May 22, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants