Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-433: Add new auth0_user_role resource #580

Merged
merged 1 commit into from
May 12, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

In this PR we are adding a new auth0_user_roles resource (1:1) to manage the assigned roles on a user.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the feature/DXCDT-433-user-role branch from 6a40619 to f013506 Compare May 12, 2023 15:45
@sergiught sergiught marked this pull request as ready for review May 12, 2023 15:45
@sergiught sergiught requested a review from a team as a code owner May 12, 2023 15:45
@sergiught sergiught changed the title Add new auth0_user_role resource DXCDT-433: Add new auth0_user_role resource May 12, 2023
@sergiught sergiught force-pushed the feature/DXCDT-433-user-role branch from f013506 to 7b3548c Compare May 12, 2023 15:50
@codecov-commenter
Copy link

Codecov Report

Merging #580 (7b3548c) into feature/DXCDT-434-user-roles (7bdb93a) will decrease coverage by 0.12%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feature/DXCDT-434-user-roles     #580      +/-   ##
================================================================
- Coverage                         87.62%   87.51%   -0.12%     
================================================================
  Files                                66       67       +1     
  Lines                             10183    10253      +70     
================================================================
+ Hits                               8923     8973      +50     
- Misses                              950      967      +17     
- Partials                            310      313       +3     
Impacted Files Coverage Δ
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/user/resource_role.go 71.42% <71.42%> (ø)

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👍

Base automatically changed from feature/DXCDT-434-user-roles to main May 12, 2023 16:13
@sergiught sergiught force-pushed the feature/DXCDT-433-user-role branch from 7b3548c to 1d6ffb4 Compare May 12, 2023 16:13
@sergiught sergiught merged commit da6394a into main May 12, 2023
@sergiught sergiught deleted the feature/DXCDT-433-user-role branch May 12, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants