-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-434: Add new auth0_user_roles resource #579
Conversation
|
||
### User Roles | ||
|
||
The `roles` field on the `auth0_user` resource will continue to be available for managing user roles. However, to ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a migration guide as we are deprecating the roles field on the user resource.
@@ -470,7 +473,7 @@ func validateNoPasswordAndEmailVerifiedSimultaneously() validateUserFunc { | |||
} | |||
} | |||
|
|||
func updateUserRoles(d *schema.ResourceData, api *management.Management) error { | |||
func persistUserRoles(d *schema.ResourceData, api *management.Management) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was conflict with updateUserRoles func for the user_roles resource, so I just renamed it. However this logic will likely go inside the auth0_user_roles file after it is removed from here.
250caf5
to
80bf9cc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 87.71% 87.62% -0.10%
==========================================
Files 65 66 +1
Lines 10114 10183 +69
==========================================
+ Hits 8872 8923 +51
- Misses 936 950 +14
- Partials 306 310 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good. Just a couple of small ideas.
### Deprecations | ||
|
||
- [User Roles](#user-roles) | ||
|
||
### User Roles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is the only notable migration component in this h2, we don't need to establish such a rigid hierarchy.
### Deprecations | |
- [User Roles](#user-roles) | |
### User Roles | |
### User Roles Deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it like this for now and change it if we release the next version without the role_permission deprecation. Wdyt? Otherwise that will have it's own h3 element as well.
80bf9cc
to
7bdb93a
Compare
🔧 Changes
In this PR we are adding a new
auth0_user_roles
resource (1:many) to manage the assigned roles on a user.📚 References
🔬 Testing
📝 Checklist