Readonly permissions field to user #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
commented
May 9, 2023
…raform-provider-auth0 into user-permissions-field
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 87.55% 87.46% -0.09%
==========================================
Files 64 64
Lines 9996 10013 +17
==========================================
+ Hits 8752 8758 +6
- Misses 941 950 +9
- Partials 303 305 +2
☔ View full report in Codecov by Sentry. |
sergiught
reviewed
May 10, 2023
| "description": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Description: "Description of the permission.", |
There was a problem hiding this comment.
Suggested change
| Description: "Description of the permission.", | |
| Description: "The description of the permission.", |
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
2 tasks
sergiught
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Before the
auth0_user_permissionandauth0_user_permissionsresources can be created, they need to be testable. And currently, there is no way to check a user's permissions (detached from role). This PR adds the read-only permissions field to user resource and data source so that the aforementioned resources can be implemented and tested.🔬 Testing
The added integration test cases are limited in strength because there is still no way to assign user permissions through Terraform. However, the cases demonstrate that the permissions do function at a base level.
📝 Checklist