Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/2] DXCDT-445: Fix created import ID on association resources #569

Merged
merged 3 commits into from
May 9, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented May 8, 2023

🔧 Changes

After #562 we stopped overriding the ID of the association resources when importing. However creating those resources without importing will still set the ID to a unique random ID. This PR fixes that.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the patch/DXCDT-445-assoc-ids branch from f198556 to 0d11e4d Compare May 8, 2023 17:27
@sergiught sergiught force-pushed the patch/DXCDT-445-assoc-ids branch from 0d11e4d to fbf1265 Compare May 9, 2023 09:40
@sergiught sergiught changed the base branch from feature/DXCDT-426-connection-clients to feature/DXCDT-426-conn-clients-part-2 May 9, 2023 09:41
@sergiught sergiught changed the title Fix created import ID on association resources [1/2] DXCDT-445: Fix created import ID on association resources May 9, 2023
@sergiught sergiught marked this pull request as ready for review May 9, 2023 09:44
@sergiught sergiught requested a review from a team as a code owner May 9, 2023 09:44
@sergiught sergiught force-pushed the feature/DXCDT-426-conn-clients-part-2 branch from 1697650 to 3d0e8d6 Compare May 9, 2023 11:18
Base automatically changed from feature/DXCDT-426-conn-clients-part-2 to main May 9, 2023 11:25
@sergiught sergiught merged commit eff561d into main May 9, 2023
@sergiught sergiught deleted the patch/DXCDT-445-assoc-ids branch May 9, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants