Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to terraform plugin testing framework #552

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Apr 18, 2023

🔧 Changes

Migrating the testing infra to the new terraform plugin testing framework. We can do this even if we haven't switched the main module to use the terraform plugin framework. More info https://developer.hashicorp.com/terraform/plugin/testing/migrating.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.97 🎉

Comparison is base (40ac9ce) 84.26% compared to head (6bfa651) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   84.26%   86.23%   +1.97%     
==========================================
  Files          78       67      -11     
  Lines       10185     9914     -271     
==========================================
- Hits         8582     8549      -33     
+ Misses       1295     1068     -227     
+ Partials      308      297      -11     
Impacted Files Coverage Δ
internal/acctest/acctest.go 0.00% <ø> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -12,7 +12,7 @@ BUILD_DIR ?= $(CURDIR)/out

GO_OS ?= $(shell go env GOOS)
GO_ARCH ?= $(shell go env GOARCH)
GO_PACKAGES := $(shell go list ./... | grep -vE "vendor|tools")
GO_PACKAGES := $(shell go list ./... | grep -vE "vendor|tools|sweep")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the sweep package to the skipped go packages as we can skip reporting on test coverage for that as it's part of the testing infra.

@sergiught sergiught marked this pull request as ready for review April 18, 2023 13:41
@sergiught sergiught requested a review from a team as a code owner April 18, 2023 13:41
@sergiught sergiught merged commit a5b6763 into main Apr 18, 2023
@sergiught sergiught deleted the patch/switch-to-plugin-testing branch April 18, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants