Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugfix-550): removing options from api schema for resourcesaver #551

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

caleyg
Copy link
Contributor

@caleyg caleyg commented Apr 7, 2023

🔧 Changes

This PR removes the invalid options spec from the API schema for resourcesaver provider in the terraform-auth0-provider.

There is an error between the actual behavior of the API found here and the provider in this repo. Removing this block from the API schema to solve this:

	"options": {
		Type:        schema.TypeMap,
		Elem:        &schema.Schema{Type: schema.TypeString},
		Optional:    true,
		Description: "Used to store additional metadata.",
	}

📚 References

terraform docs: https://registry.terraform.io/providers/auth0/auth0/latest/docs/resources/resource_server#options
auth0 API portal: https://auth0.com/docs/api/management/v2#!/Resource_Servers/post_resource_servers
github issue: #550

🔬 Testing

I have run make test-unit (on a free account), and all tests pass

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@caleyg caleyg requested a review from a team as a code owner April 7, 2023 17:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (40ac9ce) 84.26% compared to head (0902580) 84.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   84.26%   84.25%   -0.01%     
==========================================
  Files          78       78              
  Lines       10185    10183       -2     
==========================================
- Hits         8582     8580       -2     
  Misses       1295     1295              
  Partials      308      308              
Impacted Files Coverage Δ
internal/auth0/resourceserver/resource.go 84.32% <ø> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caleyg 👋🏻 thanks for putting this together 💪🏻 , I was able to verify as well that the options property has been removed from the API quite some time ago but was still lingering within this provider.

@sergiught sergiught merged commit fb72f95 into auth0:main Apr 18, 2023
@caleyg
Copy link
Contributor Author

caleyg commented Apr 18, 2023

@sergiught, thanks so much! be well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants