issue#515: Move check for config secrets from the read to the update in conn #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
sergiught
force-pushed
the
issue#515-conn-data-source-issue
branch
from
ed875de to
c8bd1c6
Compare
sergiught
force-pushed
the
issue#515-conn-data-source-issue
branch
from
c8bd1c6 to
dfa3a7c
Compare
willvedd
approved these changes
Mar 2, 2023
Widcket
approved these changes
Mar 2, 2023
sergiught
force-pushed
the
issue#515-conn-data-source-issue
branch
from
dfa3a7c to
77e0a9a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 85.39% 85.37% -0.02%
==========================================
Files 75 75
Lines 9921 9931 +10
==========================================
+ Hits 8472 8479 +7
- Misses 1145 1147 +2
- Partials 304 305 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
We are moving the check for unmanaged configuration secrets on Database Connections over from the read to the update func. The check should have only alerted the user when they're trying to update and not when reading as well, as the same func is also reused within the conn data source.
📚 References
🔬 Testing
This PR adds a new test as well that uses the import functionality of a pre-configured db conn with an unmanaged config secret. The test can only run with the test recordings due to the initial work needed to set it up.
📝 Checklist