Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue#497: Add missing prompt types #506

Merged
merged 3 commits into from
Feb 22, 2023
Merged

issue#497: Add missing prompt types #506

merged 3 commits into from
Feb 22, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Add missing prompt types to the auth0_prompty_custom_text resource validation as surfaced through #497

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review February 22, 2023 13:02
@sergiught sergiught requested a review from a team as a code owner February 22, 2023 13:02
@sergiught sergiught merged commit 5cd8c01 into main Feb 22, 2023
@sergiught sergiught deleted the issue#497-prompt-types branch February 22, 2023 14:17
@Gipphe
Copy link

Gipphe commented Feb 27, 2023

This PR accidentally removes the status prompt type, causing existing auth0_prompt_custom_text resources with prompt = "status" to fail.

@sergiught
Copy link
Contributor Author

Thanks for spotting that @Gipphe 🙏🏻 , we'll follow up with a fix.

@sergiught sergiught mentioned this pull request Feb 27, 2023
Merged
2 tasks
@sergiught
Copy link
Contributor Author

PR with the fix: #513.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiught @Gipphe @willvedd