Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-366: Expand tenant data source #479

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Feb 10, 2023

🔧 Changes

This PR expands the current tenant data source to actually include all the tenant's attributes.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the feature/DXCDT-366-tenant-data branch from 1498a41 to 640231f Compare February 10, 2023 18:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 87.11% // Head: 87.09% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (640231f) compared to base (fa06923).
Patch coverage: 89.28% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           patch/DXCDT-360-tenant-pkg     #479      +/-   ##
==============================================================
- Coverage                       87.11%   87.09%   -0.03%     
==============================================================
  Files                              52       52              
  Lines                            9548     9554       +6     
==============================================================
+ Hits                             8318     8321       +3     
- Misses                            940      942       +2     
- Partials                          290      291       +1     
Impacted Files Coverage Δ
internal/auth0/tenant/data_source.go 84.21% <89.28%> (-6.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review February 10, 2023 18:13
@sergiught sergiught requested a review from a team as a code owner February 10, 2023 18:13
Base automatically changed from patch/DXCDT-360-tenant-pkg to main February 13, 2023 09:53
@sergiught sergiught force-pushed the feature/DXCDT-366-tenant-data branch from 640231f to 686a548 Compare February 13, 2023 09:57
@sergiught sergiught merged commit a8b42f0 into main Feb 13, 2023
@sergiught sergiught deleted the feature/DXCDT-366-tenant-data branch February 13, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants