Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-353: Add fed_metadata_xml and other missing fields to adfs connection #458

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 30, 2023

🔧 Changes

As requested in #454 we are adding a way to upload the metadata source instead of pointing to a url with the file.

Various other fields are added as well to the ADFS conn options, that were missing.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review January 30, 2023 21:32
@sergiught sergiught requested a review from a team as a code owner January 30, 2023 21:32
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (issue-455/DXCDT-353-asfd-conn@dc2cbdb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             issue-455/DXCDT-353-asfd-conn     #458   +/-   ##
================================================================
  Coverage                                 ?   87.47%           
================================================================
  Files                                    ?       42           
  Lines                                    ?     9287           
  Branches                                 ?        0           
================================================================
  Hits                                     ?     8124           
  Misses                                   ?      884           
  Partials                                 ?      279           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from issue-455/DXCDT-353-asfd-conn to main January 31, 2023 09:34
@sergiught sergiught force-pushed the issue-454/DXCDT-354-adfs-metadata-xml branch from d8e3671 to 5a621a0 Compare January 31, 2023 09:35
@sergiught sergiught merged commit 54eb445 into main Jan 31, 2023
@sergiught sergiught deleted the issue-454/DXCDT-354-adfs-metadata-xml branch January 31, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants