DXCDT-351: Only send changed fields when updating a user #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Jan 30, 2023
|
|
||
| if d.IsNewResource() { | ||
| user.ID = value.String(config.GetAttr("user_id")) | ||
| } | ||
| if d.IsNewResource() || d.HasChange("email") { |
There was a problem hiding this comment.
The d.IsNewResource is unnecessary as the d.HasChange will also trigger when this is a new resource needing to be created.
Codecov ReportBase: 87.16% // Head: 87.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 87.16% 87.02% -0.15%
==========================================
Files 42 42
Lines 9264 9277 +13
==========================================
- Hits 8075 8073 -2
- Misses 914 924 +10
- Partials 275 280 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Widcket
approved these changes
Jan 30, 2023
|
Can this also be applied to other resources? |
|
Can you provide a little context for this change? Including the issue that this solves? |
willvedd
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
We're trying to always push an update to the Users API with
name,given_name,family_nameandnicknamewithin the payload.These unfortunately cannot be present in the payload if the connection is not a db or passwordless connection or if the Sync user profile attributes at each login is toggled on. For more info you can read auth0.com/docs/manage-users/user-accounts/user-profiles/configure-connection-sync-with-auth0.
📚 References
🔬 Testing
📝 Checklist