DXCDT-339: Fix issue with properties not being computed on oidc connections #443
Conversation
Codecov ReportBase: 87.11% // Head: 87.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 42 42
Lines 9192 9192
=======================================
Hits 8008 8008
Misses 910 910
Partials 274 274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -23,6 +23,7 @@ var connectionSchema = map[string]*schema.Schema{ | |||
| "display_name": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
The following option fields on the connection authorization_endpoint, issuer, jwks_uri, token_endpoint, or user_info_endpoint can be set to default values by the API
Just checking, display_name as well?
There was a problem hiding this comment.
Apparently display_name is a computed value for OIDC connection types, defaulting to the name field if not defined. It's a bit of a toss-up of wether its' worth it to mark as computed for all connections to accommodate this single connection type, but the consequences are minimal either way. @sergiught and I just changed our minds on this and decided to remove to minimize the effects for the majority of users.
🔧 Changes
The following option fields on the connection
authorization_endpoint,issuer,jwks_uri,token_endpoint, oruser_info_endpointcan be set to default values by the API, thus we need to make them Computed in order to prevent erroneous diffs when planning or applying.📚 References
🔬 Testing
📝 Checklist