Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-346: Add node18 to action resource runtime options #442

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 27, 2023

🔧 Changes

Adds support for node18 runtime within the action resource, as requested in #440.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Base: 87.11% // Head: 87.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ec8eebb) compared to base (ac1ab8e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   87.11%   87.12%           
=======================================
  Files          42       42           
  Lines        9192     9194    +2     
=======================================
+ Hits         8008     8010    +2     
  Misses        910      910           
  Partials      274      274           
Impacted Files Coverage Δ
internal/provider/resource_auth0_action.go 85.93% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review January 27, 2023 08:14
@sergiught sergiught requested a review from a team as a code owner January 27, 2023 08:14
@sergiught sergiught merged commit 2cf9d46 into main Jan 27, 2023
@sergiught sergiught deleted the issue-440/DXCDT-346-node18 branch January 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants