Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/4] Add validation to auth0_email attributes #391

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Nov 4, 2022

🔧 Changes

This change is mostly just to be more inline with the API validation so we can alert our users earlier of any issues.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Nov 4, 2022
@sergiught sergiught changed the title Add validation to auth0_email attributes [1/4] Add validation to auth0_email attributes Nov 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 86.74% // Head: 86.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a8cadec) compared to base (eeffc4b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   86.74%   86.76%   +0.01%     
==========================================
  Files          41       41              
  Lines        8730     8742      +12     
==========================================
+ Hits         7573     7585      +12     
  Misses        890      890              
  Partials      267      267              
Impacted Files Coverage Δ
internal/provider/resource_auth0_email.go 91.17% <100.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review November 4, 2022 09:08
@sergiught sergiught requested a review from a team as a code owner November 4, 2022 09:08
@sergiught sergiught merged commit 235e0ca into main Nov 7, 2022
@sergiught sergiught deleted the feature/DXCDT-255-email-provider-settings-part-1 branch November 7, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants