DXCDT-246: Add new resource to manage enabled clients on a connection #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
It has been requested through #281 to have an easier way to manage
enabled_clients
on aauth0_connection
resource so this PR introduces a brand new resourceauth0_connection_client
that does exact and only that.To note however that using both the
enabled_clients
on theauth0_connection
and this newauth0_connection_client
resource will result in unpredictable behavior and it is discouraged. To not introduce breaking changes we'll allowing for both ways of setting enabled clients to coexist. If problematic however, theenabled_clients
property on the connection might be changed to read only in the future.The new resource has no optional fields and if either the client_id or connection_id is changed, this will force the destruction of the old resource and create a new one. On the connection level, this means that the old
client_id
will get removed from theenabled_clients
and the new one added.📚 References
🔬 Testing
Other than the automated tests that were added, this can also be tested through running
make install VERSION=XX.XX.XX
and then using that in your terraform config as follows:📝 Checklist