Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-247: Update email provider if already existing when creating it #377

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 21, 2022

🔧 Changes

As requested in #330 we're improving the DX when managing email providers in the case that one was already configured in the Dashboard and we straight away want to run a terraform apply after writing our configuration, skipping the need of an import.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Oct 21, 2022
@sergiught sergiught force-pushed the patch/DXCDT-247-improve-dx-email branch from f776f29 to a4e3434 Compare October 21, 2022 17:00
@sergiught sergiught marked this pull request as ready for review October 21, 2022 17:13
@sergiught sergiught requested a review from a team as a code owner October 21, 2022 17:13
@sergiught sergiught merged commit 582190b into main Oct 24, 2022
@sergiught sergiught deleted the patch/DXCDT-247-improve-dx-email branch October 24, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants