Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-245: Add guide on how to retrieve available action triggers #370

Merged
merged 7 commits into from
Oct 19, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 17, 2022

🔧 Changes

As pointed out in #329, it's quite hard to understand what are the correct trigger versions available for an action. We're trying to make this more clear by adding a guide on how to fetch an up to date list of all the triggers and their respective actions.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)


<img alt="get_api_explorer_token_1" src="https://user-images.githubusercontent.com/28300158/196163108-1a871ae9-7d98-4c4b-bb9f-a1fbf2e3fe8f.png">

Click on the **Create & Authorize Test Application** within the **API Explorer** tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our docs guidelines state we should prefer 'Select' to 'Click' because of screen readers and similar devices (same for other instances in this file).

Copy link
Contributor Author

@sergiught sergiught Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that @Widcket 🙇🏻 , I fixed it in a122c47.

docs/resources/action.md Outdated Show resolved Hide resolved
@sergiught sergiught force-pushed the patch/DXCDT-245-actions-docs branch from edc3e86 to 34d5dae Compare October 18, 2022 07:32
@sergiught sergiught force-pushed the patch/DXCDT-245-actions-docs branch from 34d5dae to a122c47 Compare October 18, 2022 07:34
@sergiught sergiught requested review from Widcket and willvedd October 18, 2022 07:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 86.83% // Head: 86.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a122c47) compared to base (22350a8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          40       40           
  Lines        8537     8539    +2     
=======================================
+ Hits         7413     7415    +2     
  Misses        863      863           
  Partials      261      261           
Impacted Files Coverage Δ
internal/provider/resource_auth0_action.go 85.84% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught requested a review from a team October 18, 2022 16:42
@sergiught sergiught merged commit f123e66 into main Oct 19, 2022
@sergiught sergiught deleted the patch/DXCDT-245-actions-docs branch October 19, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants