Prevent erasing connection.options.configuration by mistake #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/issue#251-options.config
branch
from
fc5c15b to
2f16d47
Compare
sergiught
force-pushed
the
patch/issue#251-options.config
branch
from
2f16d47 to
1f1714f
Compare
Widcket
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As noted in #251, out of bound configuration changes are unreported and this unfortunately can cause destructive behavior if we apply the config without checking for unmanaged configuration secrets. These get encrypted and the API will return the values encrypted and not the same as we specify in the config so we can only check for unmanaged keys but not the actual values. We now send an error to the user blocking applying if we find unmanaged config keys.
📚 References
🔬 Testing
📝 Checklist