Fix data source client to search by name through all available clients #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/issue#267-data-source-per-page-search
branch
from
f69fb28 to
d4d9758
Compare
Widcket
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
It was pointed out in #267 that the current client data source stops searching based on client name after the first 50 items on the first page of the list. We're fixing that by looping through all the available pages until we find the correct client based on name. Same kind of mechanism already present here: https://github.com/auth0/go-auth0/blob/7fd1c745ba270864d3f4ac5c3284fa52f7fdf8e0/management/client_grant.go#L46
📚 References
🔬 Testing
📝 Checklist