Refactor auth0_prompt resource and add additional test case #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 85.23% 85.27% +0.04%
==========================================
Files 39 39
Lines 8227 8225 -2
==========================================
+ Hits 7012 7014 +2
+ Misses 964 960 -4
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Widcket
reviewed
Aug 26, 2022
| prompt, err := api.Prompt.Read() | ||
| if err != nil { | ||
| if mErr, ok := err.(management.Error); ok { |
There was a problem hiding this comment.
Is this not necessary for this operation?
There was a problem hiding this comment.
This was actually unnecessary because if we are getting a 404 it means the endpoint disappeared. It's not an endpoint of an ID managed resource: https://auth0.com/docs/api/management/v2#!/Prompts/get_prompts and we do want to throw that error if that happens :)
Widcket
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
#264 raises a potential issue with the auth0_prompt resource, however upon trying to reproduce I wasn't able to spot any issues with the bool flags. I ended up slightly refactoring the resource and also adding a test case to ensure the values get pushed and saved correctly.
📚 References
🔬 Testing
📝 Checklist