Refactor auth0_email and remove ForceNew on secret fields #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/issue#282-email-provider
branch
from
2971e97 to
e2ed849
Compare
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 85.30% 85.36% +0.06%
==========================================
Files 39 39
Lines 8269 8270 +1
==========================================
+ Hits 7054 7060 +6
+ Misses 964 957 -7
- Partials 251 253 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
willvedd
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
It was pointed out in #282 that for some reason any change within the secret values forces the resource to get deleted and recreated. I couldn't find any evidence or info as to why this mechanism was put in place like this. Even the secrets should be able to get updated in place without forcing a recreation of the resource as the email provider config is just a proxy to an actual external email provider.
📚 References
🔬 Testing
📝 Checklist