-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auth0_action docs #287
Conversation
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 39 39
Lines 8227 8227
=======================================
Hits 7012 7012
Misses 964 964
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -81,7 +81,7 @@ resource "auth0_action" "my_action" { | |||
Required: | |||
|
|||
- `id` (String) The trigger ID. | |||
- `version` (String) The trigger version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not control the runtime, but it does regulate which runtimes are supported.
Make sure the
version
supports the desired noderuntime
Is this actually actionable with our current documentation?
IMO, this is well intentioned, but not a final solution. I think we need to work with the relevant services to provide a more actionable error message and more documentation on the API-side. |
aeeb852
to
89c7435
Compare
Makes sense, let's just add this extra phrase then for now as a small improvement: |
🔧 Changes
Small improvement to further clarify what the version stands for within actions.supported_triggers in order to help prevent issues like #286.
📚 References
🔬 Testing
📝 Checklist