Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with organization.metadata field not getting set to empty #245

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jul 16, 2022

Description

Fixes: #236

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Jul 16, 2022
@sergiught sergiught force-pushed the patch/fix-issue236-metadata-on-orgs branch from e5b0d5c to 8c464f1 Compare July 16, 2022 09:52
@codecov-commenter
Copy link

Codecov Report

Merging #245 (8c464f1) into patch/fix-issue65-with-org-update (6f32c87) will increase coverage by 0.00%.
The diff coverage is 42.85%.

@@                        Coverage Diff                         @@
##           patch/fix-issue65-with-org-update     #245   +/-   ##
==================================================================
  Coverage                              83.27%   83.27%           
==================================================================
  Files                                     36       36           
  Lines                                   6833     6835    +2     
==================================================================
+ Hits                                    5690     5692    +2     
  Misses                                   910      910           
  Partials                                 233      233           
Impacted Files Coverage Δ
auth0/resource_auth0_organization.go 76.76% <42.85%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f32c87...8c464f1. Read the comment docs.

@sergiught sergiught force-pushed the patch/fix-issue65-with-org-update branch 2 times, most recently from d030ba2 to bfb8cf3 Compare July 18, 2022 15:28
Base automatically changed from patch/fix-issue65-with-org-update to main July 18, 2022 15:32
@sergiught sergiught force-pushed the patch/fix-issue236-metadata-on-orgs branch from 8c464f1 to 36398e8 Compare July 18, 2022 16:04
@sergiught sergiught marked this pull request as ready for review July 18, 2022 16:04
@sergiught sergiught requested a review from a team as a code owner July 18, 2022 16:04
@sergiught sergiught merged commit f92d174 into main Jul 18, 2022
@sergiught sergiught deleted the patch/fix-issue236-metadata-on-orgs branch July 18, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization metadata not being updated
3 participants