DXCDT-166: Add webauthn_platform_first_factor field to prompt resource type
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 7, 2022 08:59
…ith test changes and documentation
willvedd
commented
Jul 13, 2022
| Optional: true, | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Description: "Determines if the login screen prompts for just the identifier, identifier and password first.", |
There was a problem hiding this comment.
Just adding a description for a bit of parity.
sergiught
approved these changes
Jul 13, 2022
willvedd
deleted the
DXCDT-166-webauthn_platform_first_factor-prompt-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
webauthn_platform_first_factorboolean field to the prompt resource type. It already existed in the Go SDK so no dependent changes to merge this in. This PR is to address the request by #102 .Checklist
Note: Checklist required to be completed before a PR is considered to be reviewable.
Auth0 Code of Conduct
Auth0 General Contribution Guidelines
Changes include test coverage?
Does the description provide the correct amount of context?
Have you updated the documentation?
Is this code ready for production?