Adding sso_integration as valid app type + documentation for SSO integrations via SAMLP clients
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 35 35
Lines 6189 6189
=======================================
Hits 5194 5194
Misses 785 785
Partials 210 210
Continue to review full report at Codecov.
|
willvedd
changed the title
sso_integration as valid app type + documentation for SSO integrations via SAMLP clients
sergiught
approved these changes
Jul 7, 2022
Comment on lines
+625
to
+644
| const testAccClientSSOIntegrationCreate = ` | ||
| resource "auth0_client" "my_client" { | ||
| name = "Acceptance Test - SSO Integration - {{.testName}}" | ||
| app_type = "sso_integration" | ||
| addons{ | ||
| samlp { | ||
| audience= "http://tableau-server-test.domain.eu.com/audience" | ||
| destination= "http://tableau-server-test.domain.eu.com/destination" | ||
| digest_algorithm= "sha256" | ||
| lifetime_in_seconds= 3600 | ||
| mappings= { | ||
| email= "username" | ||
| } | ||
| name_identifier_format= "urn:oasis:names:tc:SAML:2.0:attrname-format:basic" | ||
| passthrough_claims_with_no_mapping= false | ||
| recipient= "http://tableau-server-test.domain.eu.com/recipient" | ||
| } | ||
| } | ||
| } | ||
| ` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #37 highlighted an issue around how to implement SSO integrations, specifically around the Tableau Server type. Turns out, this could be quickly supported because Tableau Server and other SSO integrations and implemented via the
samlpclient type. The only missing piece is allowingsso_integrationsto the allowable app types in the provider validation. There does not appear to be any other additional work needed to accommodate SSO integrations.This PR also attempts to make it a bit more clear through the documentation about how to implement SSO integrations with SAMLP connection type.
Checklist
Note: Checklist required to be completed before a PR is considered to be reviewable.
Auth0 Code of Conduct
Auth0 General Contribution Guidelines
Changes include test coverage?
Does the description provide the correct amount of context?
Have you updated the documentation?
Is this code ready for production?