Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/X] [DXCDT-175] Add push support to guardian resource #215

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jul 5, 2022

Description

Fixes partially: #165, more to follow after this PR. Here we focus on adding support for push notifications mfa with Guardian.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #215 (dc34f25) into feature/DXCDT-175-guardian++-part2 (85840f5) will decrease coverage by 0.73%.
The diff coverage is 49.28%.

@@                          Coverage Diff                           @@
##           feature/DXCDT-175-guardian++-part2     #215      +/-   ##
======================================================================
- Coverage                               83.72%   82.98%   -0.74%     
======================================================================
  Files                                      36       36              
  Lines                                    6401     6541     +140     
======================================================================
+ Hits                                     5359     5428      +69     
- Misses                                    818      882      +64     
- Partials                                  224      231       +7     
Impacted Files Coverage Δ
auth0/structure_auth0_guardian.go 63.58% <8.19%> (-12.85%) ⬇️
auth0/resource_auth0_guardian.go 80.32% <81.01%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85840f5...dc34f25. Read the comment docs.

@sergiught sergiught force-pushed the feature/DXCDT-175-guardian++-part2 branch from ced0d67 to 85840f5 Compare July 6, 2022 13:39
@sergiught sergiught force-pushed the feature/DXCDT-175-guardian++-part3 branch from 82ac5fb to dc34f25 Compare July 6, 2022 13:41
@sergiught sergiught marked this pull request as ready for review July 6, 2022 13:45
@sergiught sergiught requested a review from a team as a code owner July 6, 2022 13:45
@sergiught sergiught requested a review from Widcket July 6, 2022 13:46
Base automatically changed from feature/DXCDT-175-guardian++-part2 to main July 7, 2022 07:51
@sergiught sergiught merged commit a885cff into main Jul 7, 2022
@sergiught sergiught deleted the feature/DXCDT-175-guardian++-part3 branch July 7, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants