Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing tenant flags #208

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Adding missing tenant flags #208

merged 3 commits into from
Jul 6, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jun 29, 2022

Description

The Terraform PR counterpart to this Go SDK PR. Adds the following flags to the tenant resource:

  • allow_legacy_delegation_grant_types
  • allow_legacy_ro_grant_types
  • allow_legacy_tokeninfo_endpoint
  • enable_legacy_profile
  • enable_idtoken_api2
  • no_disclose_enterprise_connections
  • disable_management_api_sms_obfuscation
  • enable_adfs_waad_email_verification
  • revoke_refresh_token_grant
  • dashboard_log_streams_next
  • dashboard_insights_view
  • disable_fields_map_fix

These were all the missing flags from the API docs plus an additional requested feature flag.

This is not meant to be an exhaustive list of feature flags; there are several other feature flags that have varying degrees of support depending on the tenants. It is inevitable that we'll continually need to update this list. However, this is meant to give an honest effort about updating the support.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@willvedd willvedd requested a review from a team as a code owner June 29, 2022 20:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #208 (033a341) into main (15a253f) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   83.65%   83.88%   +0.22%     
==========================================
  Files          35       35              
  Lines        6089     6173      +84     
==========================================
+ Hits         5094     5178      +84     
  Misses        785      785              
  Partials      210      210              
Impacted Files Coverage Δ
auth0/resource_auth0_tenant.go 97.16% <100.00%> (+0.58%) ⬆️
auth0/structure_auth0_tenant.go 89.36% <100.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a253f...033a341. Read the comment docs.

@sergiught sergiught marked this pull request as draft July 5, 2022 18:37
@sergiught sergiught force-pushed the update-tenant-flags branch from 7460ac3 to 033a341 Compare July 6, 2022 09:36
@sergiught sergiught marked this pull request as ready for review July 6, 2022 09:39
@sergiught sergiught merged commit 2804d2e into main Jul 6, 2022
@sergiught sergiught deleted the update-tenant-flags branch July 6, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants