Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computed to password* fields in connection resource #191

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jun 16, 2022

Description

While investigating #108 using the reproducible:

resource "auth0_connection" "sample_connection" {
    name     = "sample-connection-issue108"
    strategy = "auth0"
    options {
        enabled_database_customization = "true"
        brute_force_protection         = true
        import_mode                    = false
        disable_signup                 = true
        requires_username              = false
        custom_scripts                 = {
            get_user = <<EOF
function getByEmail (email, callback) {
  return callback(new Error("Whoops!"))
}
EOF
        }
    }
}

On subsequent terraform plan's we would constantly get diffs on the password fields as the API assigns certain default values to them. This PR fixes that.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Jun 16, 2022
@sergiught sergiught marked this pull request as ready for review June 16, 2022 11:29
@sergiught sergiught requested a review from a team as a code owner June 16, 2022 11:29
@sergiught sergiught merged commit 6c9a323 into main Jun 17, 2022
@sergiught sergiught deleted the patch/add-computed-connection-params branch June 17, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants