Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct docs example typo binding_method to protocol_binding #179

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jasonhuling
Copy link
Contributor

Description

The parameter binding_method is referenced in the SAML example, it doesn't seem as though binding_method is a valid option. Based on the value of this parameter it looks like it should be protocol_binding.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@jasonhuling jasonhuling requested a review from a team as a code owner June 13, 2022 22:21
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@sergiught sergiught merged commit ef14e4e into auth0:main Jun 15, 2022
@jasonhuling jasonhuling deleted the patch-1 branch June 17, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants