Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3] DXCDT-103 Replace resource funcs to use context.Context and Diagnostics #126

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Apr 5, 2022

Description

With terraform-plugin-sdk@v2 we now have more support for context.Context and Diagnostics.

So in this PR we're going ahead and make use of those and remove the deprecated CRUD funcs without the context param in favour of the ones with Context.

No other changes were bundled in this PR.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Apr 5, 2022
@sergiught sergiught marked this pull request as ready for review April 5, 2022 13:20
@sergiught sergiught requested a review from a team as a code owner April 5, 2022 13:20
@sergiught sergiught changed the title DXCDT-103 Replace resource funcs to use context.Context and Diagnostics [3/3] DXCDT-103 Replace resource funcs to use context.Context and Diagnostics Apr 5, 2022
Base automatically changed from feature/DXCDT-54-sdk-v2 to main April 5, 2022 13:52
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big but sensible. Thanks for making it as focused as possible 👍

@sergiught sergiught merged commit 2b61551 into main Apr 6, 2022
@sergiught sergiught deleted the patch/DXCDT-103-post-sdk-v2-part-1 branch April 6, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants