Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new ACUL screens in supported PromptScreenMap List #1158

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ramya18101
Copy link
Contributor

🔧 Changes

Support new screens on ACUL as part of release-3:

Prompt-name Screen-name
mfa mfa-detect-browser-capabilities
mfa mfa-enroll-result
mfa mfa-begin-enroll-options
mfa-sms mfa-country-codes
mfa-email mfa-email-challenge
mfa-email mfa-email-list
mfa mfa-login-options
mfa-push mfa-push-challenge-push
mfa-push mfa-push-enrollment-qr
mfa-push mfa-push-list
mfa-push mfa-push-welcome
mfa-sms mfa-sms-challenge
mfa-sms mfa-sms-enrollment
mfa-sms mfa-sms-list

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101 ramya18101 requested a review from a team as a code owner February 21, 2025 06:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (ab4c21f) to head (d361d99).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files         134      134           
  Lines       18419    18419           
=======================================
  Hits        16428    16428           
  Misses       1409     1409           
  Partials      582      582           
Files with missing lines Coverage Δ
internal/auth0/prompt/resource_screen_render.go 88.34% <ø> (ø)

@ramya18101 ramya18101 changed the title DXCDT-894 | Include new ACUL screens in supported PromptScreenMap List Include new ACUL screens in supported PromptScreenMap List Feb 21, 2025
@ramya18101 ramya18101 merged commit d3bc204 into main Feb 21, 2025
7 checks passed
@ramya18101 ramya18101 deleted the DXCDT-894-Support-release-3-ACUL-screens-on-CDT branch February 21, 2025 08:07
@ramya18101 ramya18101 mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants