Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Passkey Support #1099

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add Passkey Support #1099

wants to merge 14 commits into from

Conversation

chrisnellis
Copy link

@chrisnellis chrisnellis commented Dec 11, 2024

🔧 Changes

📚 References

Attempting to fix #924

🔬 Testing

Ran acceptance tests, observed the recorded JSON API calls and ensured they match the API documentation

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@chrisnellis chrisnellis requested a review from a team as a code owner December 11, 2024 02:53
@duedares-rvj
Copy link
Contributor

@chrisnellis Hello!
Thank for so much for this PR.

Here's some steps to get this moving forward:

  1. We shall have to add corresponding expand and flatten rules ref: internal/auth0/connection/expand.go and flatten.go
  2. We don't need to write docs manually. You can run make lint and make generate
  3. Once you're able to test successful creation and modification of connection with this attribute, we can look back at the test cases!

Hope that helps.
Let me know if you have any questions.
Thanks!

@chrisnellis
Copy link
Author

chrisnellis commented Dec 11, 2024

@duedares-rvj , thanks for your guidance!

I just finished signing my commits after I gave the CONTRIBUTING file a read. I'll start with info from your comment and @ you again when I'm in a better place

@chrisnellis chrisnellis changed the title Add authentication methods to 'options' block Add Passkey Support Dec 13, 2024
@chrisnellis
Copy link
Author

@duedares-rvj , I think things are in a good place now for this to be reviewed :)

Let me know what you think

@chrisnellis
Copy link
Author

@kushalshit27, could you and your team please let me know what the review timeline would be for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Passkey support
2 participants