Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail fast when action fails to build #107

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

ctrombley
Copy link
Contributor

Description

Resolves #103.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • [x ] Yes
  • Not needed

Does the description provide the correct amount of context?

  • [ x] Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • [x ] Not needed

Is this code ready for production?

  • [ x] Yes, all code changes are intentional and no debugging calls are left over

@ctrombley ctrombley requested a review from a team as a code owner March 29, 2022 17:29
@ctrombley ctrombley force-pushed the fix/fail-fast-on-action-build-failure branch from cd6fc24 to c8f006a Compare March 29, 2022 17:50
@sergiught sergiught self-requested a review March 30, 2022 12:11
@sergiught sergiught self-assigned this Mar 30, 2022
@sergiught
Copy link
Contributor

Hey @ctrombley really appreciate the contribution. I'll have some time to review this later today or tomorrow. Thanks for your patience 🙇🏻

@sergiught
Copy link
Contributor

@ctrombley Thanks a lot for this contribution. I reviewed it and it's a perfectly sensible approach for the issue.

Apologies for the conflicts that have arisen as I was working on the action resource recently, I can go ahead and fix them for you or you can rebase against latest master, up to you. Just let me know:) Happy to help.

@sergiught sergiught force-pushed the fix/fail-fast-on-action-build-failure branch from c8f006a to f687406 Compare March 31, 2022 16:18
@sergiught
Copy link
Contributor

@ctrombley I went ahead and rebased to save you some time and bundled the changes within this commit:

Thanks a lot again, great contribution!

@sergiught
Copy link
Contributor

Note for other folks checking this: tests are failing as this contribution is coming from a fork. Ran the tests manually for the action locally and they pass.

--- PASS: TestAccAction_FailedBuild (9.36s)
PASS

Process finished with the exit code 0

@sergiught sergiught merged commit 73617b5 into auth0:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action creation is timing out
2 participants