Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for user_id_attribute for AzureAD connection options #1047

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Oct 9, 2024

The documentation and examples for Microsoft Azure AD connections gave an invalid value for user_id_attribute. The only valid values according to their documentation are sub and oid

🔧 Changes

Updated example for resource auth0_connection for AzureAD

📚 References

https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference#use-claims-to-reliably-identify-a-user

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (48a1d05) to head (1e49ae3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         126      126           
  Lines       17462    17462           
=======================================
  Hits        15606    15606           
  Misses       1317     1317           
  Partials      539      539           

@acwest acwest marked this pull request as ready for review October 9, 2024 14:19
@acwest acwest requested a review from a team as a code owner October 9, 2024 14:19
@acwest acwest merged commit de35ea1 into main Oct 9, 2024
9 checks passed
@acwest acwest deleted the ESD-40277-fix-docs-for-azure-user_id_attribute branch October 9, 2024 14:21
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
…1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
…1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options
Signed-off-by: BryanLewis-AtOkta <[email protected]>
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
…1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options
Signed-off-by: BryanLewis-AtOkta <[email protected]>
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
… for Verify.

Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017)

* Removed min/max validation on precendence slice

* reverted maxItems validation

Add support for all languages for Universal Login (auth0#1016)

* Fetch list of languages from CDN instead of hardcoding them

* Updated linting

---------

Co-authored-by: KunalOfficial <[email protected]>

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources  (auth0#1013)

* Add-Support-for-Prompt-Screen-Partials

* Add auth0_prompt_screen_partial Resource and Required Docs

* Fix Linting

* Updated Go-auth0 Version 1.9.0 to 1.10.0

* Added Testcases for other insertionpoints as well

* Fixed Linting

* Added More testcases

* Correct depends on for datasource of prompt partials

Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999)

Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add Organizations for Client Credentials (auth0#1009)

* Updated schema and added relevant test cases for client with default_organization

* Added test recordings

* Updated the resource schema and added new test recordinging

* Added validation on required arguments

* Fixed linting and updated test recording

* Deleted a test recording

* Updated go.mod

Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019)

* Change screen_partials to TypeSet for consistent ordering in prompt screen partials

* Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues

Add changelog for v1.6.0 (auth0#1020)

* Added the changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Patch: default_organization on Client Creds (auth0#1021)

* Updated flow of importing default_organization

* Updated logic for handling default Orgs

* Updated test recordings

* Updated the conditional check

Add changelog for v1.6.1 (auth0#1022)

* Added changelog

* linting fixes

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Add HRI related changes to Terraform provider (auth0#1015)

* Add HRI related changes to Terraform provider

* Fix broken HasChange behaviour

* Change ConflictWith to explicit validation in code

* Move validation to plan instead of apply

* Fix validation for default resources

Add strategy_version support to all connections that use it (auth0#1024)

* ESD-39527: Add strategy_version support to all connections that use it

* Update go-auth0 dependency

* Add examples for strategy_version

Add user_id_attribute support to AzureAD connection options (auth0#1028)

Add user_id_attribute to AzureAD connection options

Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036)

Bump github.com/auth0/go-auth0

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added some minor updates

Updated recordings

docs updated

Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031)

* Add auth0_encryption_key resource to allow rekeying of tenant encryption keys

* Slight renaming, and use key_rotation_id instead of rekey attribute

* Rename auth0_encryption_key to auth0_encryption_key_manager

Add new resource to manage Organization Client Grants (auth0#1027)

* Added new resource and data source for org client grants

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

* rebased

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

---------

Co-authored-by: A. Craig West <[email protected]>

Add support for Form, Flow and Flow Vault Connection (auth0#1039)

* form resource

* flow resource

* flow resource, data source added

* update forms

* update flow

* update go-auth0 v1.11.0

* added flow vault connection

* Added flow expand/flatten + tests + recordings

* update flow vault connection

* form, flow vault connection added unit test, recordings

* form, flow vault connection doc update

* form, flow vault connection examples added

* form, flow vault connection examples added example, data source

* form, flow vault connection examples docs updated

* lint fix

* form, flow unit test added

* form flatten unit test added

* lint

* Updated recordings

---------

Co-authored-by: kushalshit27 <[email protected]>

PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043)

Fix: Ensure Removal of Insertion Points in  Resource API

Support BYOK in Terraform provider (auth0#1041)

Co-authored-by: KunalOfficial <[email protected]>

Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add changelog for 1.7.0 (auth0#1044)

* Added changelog for 1.7.0

* Added further changes

* removed .

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* removed .

* minor refactor

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix docs for user_id_attribute for AzureAD connection options (auth0#1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options

PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049)

* Added check on tenants which has insufficient scopes and return a empty slice

* Updated test case

* minor refactoring

* minor refactor

* linting

* linting

Updated example for Form (auth0#1046)

* Updated example for form

PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048)

* Implemented checkpoint pagination on role users

* added tests

Add changelog for 1.7.1 (auth0#1050)

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Apply suggestions from code review

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Added changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052)

Updated recording + auth0 version bump

Added a check on provider's configuration for required env vars (auth0#1053)

* Added a check on provider's configuration for reqd env vars

* Added linting
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
… for Verify.

Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017)

* Removed min/max validation on precendence slice

* reverted maxItems validation

Add support for all languages for Universal Login (auth0#1016)

* Fetch list of languages from CDN instead of hardcoding them

* Updated linting

---------

Co-authored-by: KunalOfficial <[email protected]>

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources  (auth0#1013)

* Add-Support-for-Prompt-Screen-Partials

* Add auth0_prompt_screen_partial Resource and Required Docs

* Fix Linting

* Updated Go-auth0 Version 1.9.0 to 1.10.0

* Added Testcases for other insertionpoints as well

* Fixed Linting

* Added More testcases

* Correct depends on for datasource of prompt partials

Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999)

Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add Organizations for Client Credentials (auth0#1009)

* Updated schema and added relevant test cases for client with default_organization

* Added test recordings

* Updated the resource schema and added new test recordinging

* Added validation on required arguments

* Fixed linting and updated test recording

* Deleted a test recording

* Updated go.mod

Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019)

* Change screen_partials to TypeSet for consistent ordering in prompt screen partials

* Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues

Add changelog for v1.6.0 (auth0#1020)

* Added the changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Patch: default_organization on Client Creds (auth0#1021)

* Updated flow of importing default_organization

* Updated logic for handling default Orgs

* Updated test recordings

* Updated the conditional check

Add changelog for v1.6.1 (auth0#1022)

* Added changelog

* linting fixes

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Add HRI related changes to Terraform provider (auth0#1015)

* Add HRI related changes to Terraform provider

* Fix broken HasChange behaviour

* Change ConflictWith to explicit validation in code

* Move validation to plan instead of apply

* Fix validation for default resources

Add strategy_version support to all connections that use it (auth0#1024)

* ESD-39527: Add strategy_version support to all connections that use it

* Update go-auth0 dependency

* Add examples for strategy_version

Add user_id_attribute support to AzureAD connection options (auth0#1028)

Add user_id_attribute to AzureAD connection options

Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036)

Bump github.com/auth0/go-auth0

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added some minor updates

Updated recordings

docs updated

Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031)

* Add auth0_encryption_key resource to allow rekeying of tenant encryption keys

* Slight renaming, and use key_rotation_id instead of rekey attribute

* Rename auth0_encryption_key to auth0_encryption_key_manager

Add new resource to manage Organization Client Grants (auth0#1027)

* Added new resource and data source for org client grants

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

* rebased

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

---------

Co-authored-by: A. Craig West <[email protected]>

Add support for Form, Flow and Flow Vault Connection (auth0#1039)

* form resource

* flow resource

* flow resource, data source added

* update forms

* update flow

* update go-auth0 v1.11.0

* added flow vault connection

* Added flow expand/flatten + tests + recordings

* update flow vault connection

* form, flow vault connection added unit test, recordings

* form, flow vault connection doc update

* form, flow vault connection examples added

* form, flow vault connection examples added example, data source

* form, flow vault connection examples docs updated

* lint fix

* form, flow unit test added

* form flatten unit test added

* lint

* Updated recordings

---------

Co-authored-by: kushalshit27 <[email protected]>

PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043)

Fix: Ensure Removal of Insertion Points in  Resource API

Support BYOK in Terraform provider (auth0#1041)

Co-authored-by: KunalOfficial <[email protected]>

Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add changelog for 1.7.0 (auth0#1044)

* Added changelog for 1.7.0

* Added further changes

* removed .

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* removed .

* minor refactor

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix docs for user_id_attribute for AzureAD connection options (auth0#1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options

PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049)

* Added check on tenants which has insufficient scopes and return a empty slice

* Updated test case

* minor refactoring

* minor refactor

* linting

* linting

Updated example for Form (auth0#1046)

* Updated example for form

PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048)

* Implemented checkpoint pagination on role users

* added tests

Add changelog for 1.7.1 (auth0#1050)

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Apply suggestions from code review

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Added changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052)

Updated recording + auth0 version bump

Added a check on provider's configuration for required env vars (auth0#1053)

* Added a check on provider's configuration for reqd env vars

* Added linting
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
… for Verify.

Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017)

* Removed min/max validation on precendence slice

* reverted maxItems validation

Add support for all languages for Universal Login (auth0#1016)

* Fetch list of languages from CDN instead of hardcoding them

* Updated linting

---------

Co-authored-by: KunalOfficial <[email protected]>

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources  (auth0#1013)

* Add-Support-for-Prompt-Screen-Partials

* Add auth0_prompt_screen_partial Resource and Required Docs

* Fix Linting

* Updated Go-auth0 Version 1.9.0 to 1.10.0

* Added Testcases for other insertionpoints as well

* Fixed Linting

* Added More testcases

* Correct depends on for datasource of prompt partials

Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999)

Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add Organizations for Client Credentials (auth0#1009)

* Updated schema and added relevant test cases for client with default_organization

* Added test recordings

* Updated the resource schema and added new test recordinging

* Added validation on required arguments

* Fixed linting and updated test recording

* Deleted a test recording

* Updated go.mod

Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019)

* Change screen_partials to TypeSet for consistent ordering in prompt screen partials

* Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues

Add changelog for v1.6.0 (auth0#1020)

* Added the changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Patch: default_organization on Client Creds (auth0#1021)

* Updated flow of importing default_organization

* Updated logic for handling default Orgs

* Updated test recordings

* Updated the conditional check

Add changelog for v1.6.1 (auth0#1022)

* Added changelog

* linting fixes

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Add HRI related changes to Terraform provider (auth0#1015)

* Add HRI related changes to Terraform provider

* Fix broken HasChange behaviour

* Change ConflictWith to explicit validation in code

* Move validation to plan instead of apply

* Fix validation for default resources

Add strategy_version support to all connections that use it (auth0#1024)

* ESD-39527: Add strategy_version support to all connections that use it

* Update go-auth0 dependency

* Add examples for strategy_version

Add user_id_attribute support to AzureAD connection options (auth0#1028)

Add user_id_attribute to AzureAD connection options

Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036)

Bump github.com/auth0/go-auth0

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added some minor updates

Updated recordings

docs updated

Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031)

* Add auth0_encryption_key resource to allow rekeying of tenant encryption keys

* Slight renaming, and use key_rotation_id instead of rekey attribute

* Rename auth0_encryption_key to auth0_encryption_key_manager

Add new resource to manage Organization Client Grants (auth0#1027)

* Added new resource and data source for org client grants

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

* rebased

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

---------

Co-authored-by: A. Craig West <[email protected]>

Add support for Form, Flow and Flow Vault Connection (auth0#1039)

* form resource

* flow resource

* flow resource, data source added

* update forms

* update flow

* update go-auth0 v1.11.0

* added flow vault connection

* Added flow expand/flatten + tests + recordings

* update flow vault connection

* form, flow vault connection added unit test, recordings

* form, flow vault connection doc update

* form, flow vault connection examples added

* form, flow vault connection examples added example, data source

* form, flow vault connection examples docs updated

* lint fix

* form, flow unit test added

* form flatten unit test added

* lint

* Updated recordings

---------

Co-authored-by: kushalshit27 <[email protected]>

PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043)

Fix: Ensure Removal of Insertion Points in  Resource API

Support BYOK in Terraform provider (auth0#1041)

Co-authored-by: KunalOfficial <[email protected]>

Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add changelog for 1.7.0 (auth0#1044)

* Added changelog for 1.7.0

* Added further changes

* removed .

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* removed .

* minor refactor

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix docs for user_id_attribute for AzureAD connection options (auth0#1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options

PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049)

* Added check on tenants which has insufficient scopes and return a empty slice

* Updated test case

* minor refactoring

* minor refactor

* linting

* linting

Updated example for Form (auth0#1046)

* Updated example for form

PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048)

* Implemented checkpoint pagination on role users

* added tests

Add changelog for 1.7.1 (auth0#1050)

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Apply suggestions from code review

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Added changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052)

Updated recording + auth0 version bump

Added a check on provider's configuration for required env vars (auth0#1053)

* Added a check on provider's configuration for reqd env vars

* Added linting
BryanLewis-AtOkta pushed a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
… for Verify.

Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017)

* Removed min/max validation on precendence slice

* reverted maxItems validation

Add support for all languages for Universal Login (auth0#1016)

* Fetch list of languages from CDN instead of hardcoding them

* Updated linting

---------

Co-authored-by: KunalOfficial <[email protected]>

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources  (auth0#1013)

* Add-Support-for-Prompt-Screen-Partials

* Add auth0_prompt_screen_partial Resource and Required Docs

* Fix Linting

* Updated Go-auth0 Version 1.9.0 to 1.10.0

* Added Testcases for other insertionpoints as well

* Fixed Linting

* Added More testcases

* Correct depends on for datasource of prompt partials

Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999)

Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add Organizations for Client Credentials (auth0#1009)

* Updated schema and added relevant test cases for client with default_organization

* Added test recordings

* Updated the resource schema and added new test recordinging

* Added validation on required arguments

* Fixed linting and updated test recording

* Deleted a test recording

* Updated go.mod

Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019)

* Change screen_partials to TypeSet for consistent ordering in prompt screen partials

* Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues

Add changelog for v1.6.0 (auth0#1020)

* Added the changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Patch: default_organization on Client Creds (auth0#1021)

* Updated flow of importing default_organization

* Updated logic for handling default Orgs

* Updated test recordings

* Updated the conditional check

Add changelog for v1.6.1 (auth0#1022)

* Added changelog

* linting fixes

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Add HRI related changes to Terraform provider (auth0#1015)

* Add HRI related changes to Terraform provider

* Fix broken HasChange behaviour

* Change ConflictWith to explicit validation in code

* Move validation to plan instead of apply

* Fix validation for default resources

Add strategy_version support to all connections that use it (auth0#1024)

* ESD-39527: Add strategy_version support to all connections that use it

* Update go-auth0 dependency

* Add examples for strategy_version

Add user_id_attribute support to AzureAD connection options (auth0#1028)

Add user_id_attribute to AzureAD connection options

Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036)

Bump github.com/auth0/go-auth0

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added some minor updates

Updated recordings

docs updated

Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031)

* Add auth0_encryption_key resource to allow rekeying of tenant encryption keys

* Slight renaming, and use key_rotation_id instead of rekey attribute

* Rename auth0_encryption_key to auth0_encryption_key_manager

Add new resource to manage Organization Client Grants (auth0#1027)

* Added new resource and data source for org client grants

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

* rebased

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

---------

Co-authored-by: A. Craig West <[email protected]>

Add support for Form, Flow and Flow Vault Connection (auth0#1039)

* form resource

* flow resource

* flow resource, data source added

* update forms

* update flow

* update go-auth0 v1.11.0

* added flow vault connection

* Added flow expand/flatten + tests + recordings

* update flow vault connection

* form, flow vault connection added unit test, recordings

* form, flow vault connection doc update

* form, flow vault connection examples added

* form, flow vault connection examples added example, data source

* form, flow vault connection examples docs updated

* lint fix

* form, flow unit test added

* form flatten unit test added

* lint

* Updated recordings

---------

Co-authored-by: kushalshit27 <[email protected]>

PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043)

Fix: Ensure Removal of Insertion Points in  Resource API

Support BYOK in Terraform provider (auth0#1041)

Co-authored-by: KunalOfficial <[email protected]>

Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add changelog for 1.7.0 (auth0#1044)

* Added changelog for 1.7.0

* Added further changes

* removed .

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* removed .

* minor refactor

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix docs for user_id_attribute for AzureAD connection options (auth0#1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options

PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049)

* Added check on tenants which has insufficient scopes and return a empty slice

* Updated test case

* minor refactoring

* minor refactor

* linting

* linting

Updated example for Form (auth0#1046)

* Updated example for form

PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048)

* Implemented checkpoint pagination on role users

* added tests

Add changelog for 1.7.1 (auth0#1050)

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Apply suggestions from code review

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Added changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052)

Updated recording + auth0 version bump

Added a check on provider's configuration for required env vars (auth0#1053)

* Added a check on provider's configuration for reqd env vars

* Added linting
BryanLewis-AtOkta added a commit to BryanLewis-AtOkta/terraform-provider-auth0 that referenced this pull request Oct 24, 2024
… for Verify.

Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017)

* Removed min/max validation on precendence slice

* reverted maxItems validation

Add support for all languages for Universal Login (auth0#1016)

* Fetch list of languages from CDN instead of hardcoding them

* Updated linting

---------

Co-authored-by: KunalOfficial <[email protected]>

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources  (auth0#1013)

* Add-Support-for-Prompt-Screen-Partials

* Add auth0_prompt_screen_partial Resource and Required Docs

* Fix Linting

* Updated Go-auth0 Version 1.9.0 to 1.10.0

* Added Testcases for other insertionpoints as well

* Fixed Linting

* Added More testcases

* Correct depends on for datasource of prompt partials

Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999)

Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add Organizations for Client Credentials (auth0#1009)

* Updated schema and added relevant test cases for client with default_organization

* Added test recordings

* Updated the resource schema and added new test recordinging

* Added validation on required arguments

* Fixed linting and updated test recording

* Deleted a test recording

* Updated go.mod

Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019)

* Change screen_partials to TypeSet for consistent ordering in prompt screen partials

* Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues

Add changelog for v1.6.0 (auth0#1020)

* Added the changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Patch: default_organization on Client Creds (auth0#1021)

* Updated flow of importing default_organization

* Updated logic for handling default Orgs

* Updated test recordings

* Updated the conditional check

Add changelog for v1.6.1 (auth0#1022)

* Added changelog

* linting fixes

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Add HRI related changes to Terraform provider (auth0#1015)

* Add HRI related changes to Terraform provider

* Fix broken HasChange behaviour

* Change ConflictWith to explicit validation in code

* Move validation to plan instead of apply

* Fix validation for default resources

Add strategy_version support to all connections that use it (auth0#1024)

* ESD-39527: Add strategy_version support to all connections that use it

* Update go-auth0 dependency

* Add examples for strategy_version

Add user_id_attribute support to AzureAD connection options (auth0#1028)

Add user_id_attribute to AzureAD connection options

Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036)

Bump github.com/auth0/go-auth0

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added some minor updates

Updated recordings

docs updated

Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031)

* Add auth0_encryption_key resource to allow rekeying of tenant encryption keys

* Slight renaming, and use key_rotation_id instead of rekey attribute

* Rename auth0_encryption_key to auth0_encryption_key_manager

Add new resource to manage Organization Client Grants (auth0#1027)

* Added new resource and data source for org client grants

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

* rebased

* minor refactoring

* Added test case

* Updated test recordings

* Updated the test name

* Fix some timing issues in resourceserver, and add terraform version to server logs

* Remove unneeded lint config

---------

Co-authored-by: A. Craig West <[email protected]>

Add support for Form, Flow and Flow Vault Connection (auth0#1039)

* form resource

* flow resource

* flow resource, data source added

* update forms

* update flow

* update go-auth0 v1.11.0

* added flow vault connection

* Added flow expand/flatten + tests + recordings

* update flow vault connection

* form, flow vault connection added unit test, recordings

* form, flow vault connection doc update

* form, flow vault connection examples added

* form, flow vault connection examples added example, data source

* form, flow vault connection examples docs updated

* lint fix

* form, flow unit test added

* form flatten unit test added

* lint

* Updated recordings

---------

Co-authored-by: kushalshit27 <[email protected]>

PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043)

Fix: Ensure Removal of Insertion Points in  Resource API

Support BYOK in Terraform provider (auth0#1041)

Co-authored-by: KunalOfficial <[email protected]>

Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add changelog for 1.7.0 (auth0#1044)

* Added changelog for 1.7.0

* Added further changes

* removed .

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* removed .

* minor refactor

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix docs for user_id_attribute for AzureAD connection options (auth0#1047)

ESD-40277: Fix docs for user_id_attribute for AzureAD connection options

PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049)

* Added check on tenants which has insufficient scopes and return a empty slice

* Updated test case

* minor refactoring

* minor refactor

* linting

* linting

Updated example for Form (auth0#1046)

* Updated example for form

PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048)

* Implemented checkpoint pagination on role users

* added tests

Add changelog for 1.7.1 (auth0#1050)

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Apply suggestions from code review

Co-authored-by: KunalOfficial <[email protected]>

* Added changelog

* refac

* refac

* refac

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

* refac

* Added changelog

* Update CHANGELOG.md

Co-authored-by: KunalOfficial <[email protected]>

---------

Co-authored-by: KunalOfficial <[email protected]>

Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052)

Updated recording + auth0 version bump

Added a check on provider's configuration for required env vars (auth0#1053)

* Added a check on provider's configuration for reqd env vars

* Added linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants