Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88 - Pass errors to next in express #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zxlin
Copy link

@zxlin zxlin commented Dec 19, 2019

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This PR specifically addresses #88

Errors produced in the auth middleware will now be passed into next in the express middleware chain.

This is likely considered a breaking change as behavior that was once handled by the lib will now be the responsibility of the end user. However, this adds customizability to the user of the lib to allow custom error handling and such.

References

See issue #88

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@zxlin
Copy link
Author

zxlin commented Apr 29, 2020

hi @ziluvatar & @luuuis, who would be the best to review this change?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant