Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support signed logout response sent via POST #140

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ArtiomCiumac
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This fixes checking for signed LogoutResponse during SLO scenarios when the app posts the response via POST. In such situation the code was still trying to load the signature from query and was failing to do so.

Testing

Set up SAML SLO with 2 applications:

  1. Set up applications in Auth0 with SLO configured and a custom signing certificate as per docs page.
  2. Set up two applications to sign their requests with a self-signed certificate.
  3. Set up the applications to send their requests via POST, but leave the settings on Auth0 side by default (which would use Redirect to send the responses to the apps - note that mixed bindings are fully allowed by the spec).
  4. Log into both applications.
  5. Initiate a Single Log Out.

Expected results after this PR:

The SLO should complete and it should be visible in browser dev tools that the app sends signed responses across all SAML requests.

Actual results before this PR:

The second session participant app LogoutResults fails the verification on the IDP side (this lib).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Copy link
Contributor

@machadolucasvp machadolucasvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtiomCiumac ArtiomCiumac merged commit 5274d62 into master Nov 17, 2023
7 checks passed
@machadolucasvp machadolucasvp mentioned this pull request Nov 20, 2023
4 tasks
@machadolucasvp machadolucasvp changed the title fix: support signed logout resposne sent via POST fix: support signed logout response sent via POST Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants