Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export error types [SDK-2941] #46

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Export error types [SDK-2941] #46

merged 1 commit into from
Dec 15, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Description

Export InsufficientScopeError, InvalidRequestError, InvalidTokenError, UnauthorizedError from express-oauth2-jwt-bearer

References

Required for https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner December 15, 2021 12:33
adamjmcgrath
adamjmcgrath commented Dec 15, 2021
View reviewed changes
packages/express-oauth2-jwt-bearer/src/index.ts
next(e);
}
};
const toHandler =
Copy link
Contributor Author

@adamjmcgrath adamjmcgrath Dec 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prettier doing a whitespace change

@adamjmcgrath adamjmcgrath merged commit 0b65192 into main Dec 15, 2021
@adamjmcgrath adamjmcgrath deleted the export-errs branch December 15, 2021 14:27
@adamjmcgrath adamjmcgrath mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @frederikprijck