Bundle type definitions for monorepo packages #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
commented
Oct 25, 2021
| @@ -3,7 +3,6 @@ | |||
| "compilerOptions": { | |||
| "allowJs": true, | |||
| "removeComments": true, | |||
| "declaration": true, | |||
There was a problem hiding this comment.
We're using rollup-plugin-dts to provide the type declaration rather than typescript
adamjmcgrath
commented
Oct 25, 2021
| @@ -32,6 +32,7 @@ module.exports = { | |||
| 'oauth2-bearer': ['../oauth2-bearer/src'], | |||
| 'access-token-jwt': ['../access-token-jwt/src'], | |||
| }, | |||
| useUnknownInCatchVariables: false, | |||
There was a problem hiding this comment.
rollup-plugin-dts brought in a new version of TS with a breaking change around errors being unknown by default. Which was causing some tests to fail.
This disables the breaking change for the tests (in ts-jest)
stevehobbsdev
approved these changes
Oct 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should bundle type definitions as well as typescript files for private monorepo packages (
access-token-jwtandoauth2-bearer)References
fixes #38
Testing
Tested by installing the fix locally
Checklist
master