Fix retrieveSigningKeys error (#242)

* Update utils.js

* Update .eslintrc and fix linting errors

.eslintrc

@@ -21,6 +21,9 @@
     "space-before-blocks": [2, "always"]
   },
   "env": {
-    "node": true
-  }
+    "node": true,
+    "mocha": true,
+    "es6": true
+  },
+  "extends": "eslint:recommended"
 }

src/integrations/express.js

@@ -20,10 +20,10 @@ module.exports.expressJwtSecret = function (options) {
   }
 
   const client = new JwksClient(options);
-  const onError = options.handleSigningKeyError || handleSigningKeyError;
+  const onError = options.handleSigningKeyError || handleSigningKeyError;
 
   return function secretProvider(req, header, payload, cb) {
-    if (!header || !supportedAlg.includes(header.alg)) {
+    if (!header || !supportedAlg.includes(header.alg)) {
       return cb(null, null);
     }
 

src/integrations/hapi.js

@@ -37,7 +37,7 @@ module.exports.hapiJwt2Key = function (options) {
   }
 
   const client = new JwksClient(options);
-  const onError = options.handleSigningKeyError || handleSigningKeyError;
+  const onError = options.handleSigningKeyError || handleSigningKeyError;
 
   return function secretProvider(decoded, cb) {
     // We cannot find a signing certificate if there is no header (no kid).

src/integrations/passport.js

@@ -25,13 +25,15 @@ module.exports.passportJwtSecret = function (options) {
   }
 
   const client = new JwksClient(options);
-  const onError = options.handleSigningKeyError || handleSigningKeyError;
+  const onError = options.handleSigningKeyError || handleSigningKeyError;
 
   return function secretProvider(req, rawJwtToken, cb) {
     let decoded;
     try {
       decoded = JWT.decode(rawJwtToken, { complete: true });
-    } catch (err) {}
+    } catch (err) {
+      decoded = null;
+    }
 
     if (!decoded || !supportedAlg.includes(decoded.header.alg)) {
       return cb(null, null);

src/utils.js

@@ -1,13 +1,8 @@
 const jose = require('jose');
-const JwksError = require('./errors/JwksError');
 
 function retrieveSigningKeys(keys) {
-  let keystore = [];
-  try {
-    keystore = jose.JWKS.asKeyStore({ keys }, { ignoreErrors: true });
-  } catch (err) {
-    return cb(new JwksError(err.message));
-  }
+  const keystore = jose.JWKS.asKeyStore({ keys }, { ignoreErrors: true });
+
   return keystore.all({ use: 'sig' }).map((key) => {
     return {
       kid: key.kid,

src/wrappers/cache.js

@@ -1,7 +1,7 @@
 const debug = require('debug');
 const memoizer = require('lru-memoizer');
 
-function cacheWrapper(client, { cacheMaxEntries = 5, cacheMaxAge = 600000 } = options) {
+function cacheWrapper(client, { cacheMaxEntries = 5, cacheMaxAge = 600000 }) {
   const logger = debug('jwks');
   logger(`Configured caching of signing keys. Max: ${cacheMaxEntries} / Age: ${cacheMaxAge}`);
   return memoizer.sync({

src/wrappers/interceptor.js

@@ -4,7 +4,7 @@ const retrieveSigningKeys = require('../utils').retrieveSigningKeys;
  * Uses getKeysInterceptor to allow users to retrieve keys from a file,
  * external cache, or provided object before falling back to the jwksUri endpoint
  */
-function getKeysInterceptor(client, { getKeysInterceptor } = options) {
+function getKeysInterceptor(client, { getKeysInterceptor }) {
   const getSigningKey = client.getSigningKey.bind(client);
 
   return async (kid) => {

src/wrappers/rateLimit.js

@@ -3,7 +3,7 @@ const { RateLimiter } = require('limiter');
 
 const JwksRateLimitError = require('../errors/JwksRateLimitError');
 
-function rateLimtWrapper(client, { jwksRequestsPerMinute = 10 } = options) {
+function rateLimtWrapper(client, { jwksRequestsPerMinute = 10 }) {
   const logger = debug('jwks');
   const getSigningKey = client.getSigningKey.bind(client);