Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for using persistent connections #919

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

alaczi
Copy link
Contributor

@alaczi alaczi commented Aug 23, 2023

Changes

Exposing the underlying library's - (rest-facade) options for keepAlive connections

We experienced a lot of ETIMEDOUT errors during our load tests and keeping alive connections mitigated the errors.

Note: more work needed for auth/TokensManager and auth/UsersManager as that is using axios (static way) to do the calls. To be able to use keepAlive there an axios instance need to be created and reused in the requests.

References

#545

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@alaczi alaczi requested a review from a team as a code owner August 23, 2023 13:20
@alaczi alaczi changed the title Feat/timeout feat: allow configuration of keeping the connections alive Aug 23, 2023
@alaczi alaczi changed the title feat: allow configuration of keeping the connections alive feat: allow configuration for using persistent connections Aug 23, 2023
@alaczi alaczi changed the title feat: allow configuration for using persistent connections feat: add configuration for using persistent connections Aug 23, 2023
@adamjmcgrath
Copy link
Contributor

Thanks for raising this @alaczi - I'll take a look at it early next week

Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alaczi

@adamjmcgrath adamjmcgrath merged commit 01b9336 into auth0:master Aug 29, 2023
4 checks passed
@adamjmcgrath adamjmcgrath mentioned this pull request Aug 29, 2023
@alaczi alaczi deleted the feat/timeout branch September 7, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants