Use id instead of action_id as per the mgmt api. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seejee
reviewed
May 20, 2021
davidpatrick
force-pushed
the
actionsManager
branch
from
0b87bbd to
0b4247e
Compare
davidpatrick
force-pushed
the
actionsManager
branch
from
0b4247e to
53496df
Compare
@davidpatrick is this something you guys can handle? I'm not sure how to make it backwards compatible. |
|
Hey @stevezau I've already gone and updated the PR with the changes. Thanks for the response |
davidpatrick
approved these changes
Jun 16, 2021
seejee
reviewed
Jun 16, 2021
| if (params.action_id) { | ||
| params.id = params.action_id; | ||
| delete params.action_id; | ||
| } |
seejee
approved these changes
Jun 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated API to use id instead of
trigger_idaction_id so it repesents the management API.