Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Streams CRUD Ops support #511

Closed
wants to merge 11 commits into from
Closed

Conversation

cv711
Copy link
Contributor

@cv711 cv711 commented Jul 21, 2020

Changes

The new class that was added is called LogStreamsManager and it's adding the following endpoints:

  • GET /api/v2/log-streams
  • GET /api/v2/log-streams/{id}
  • POST /api/v2/log-streams
  • PATCH /api/v2/log-streams/{id}
  • DELETE /api/v2/log-streams/{id}

References

The relevant operations for Log Streams are described here

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@cv711 cv711 requested a review from a team July 21, 2020 14:43
@cv711 cv711 changed the title Feat log streams Log Streams CRUD Ops support Jul 21, 2020
@cv711
Copy link
Contributor Author

cv711 commented Jul 23, 2020

Hey! Any feedback on this one?
Also side note: the relevant docs here have a typo the httpAuthorizationHeader field should be httpAuthorization but I don't have access to the api2 repo to open a proper issue there.

@cv711 cv711 mentioned this pull request Jul 24, 2020
5 tasks
@cv711 cv711 closed this Jul 24, 2020
@cv711 cv711 deleted the feat-log-streams branch July 24, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant