-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing endpoints for feature Organizations for Client Credentials changes #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duedares-rvj
previously approved these changes
Oct 21, 2024
tusharpandey13
force-pushed
the
org-cc-missing-endpoints
branch
from
October 21, 2024 12:23
0c8a4aa
to
4b95784
Compare
…oken as claims during auth
kushalshit27
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check getOrganizationClientGrants pagination params also from api.json
Please add SDK usage examples |
…e facing issues with codecov CI tasks failing due to uncovered lines in indirect changes
nandan-bhat
approved these changes
Oct 29, 2024
tusharpandey13
commented
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kushalshit27
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added 2 missing endpoints for the feature organization support for client credentials and respective tests:
This PR also contains auth related changes for GA release of feature
Organizations for Client Credentials
as quoted:Respective failing tests after removal of these checks have been removed.
References
Please look at #1033
API docs are not public yet.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist