Create package.json after cleaning build directory
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
commented
Sep 1, 2023
|
Looks like the recently released NPM 10 is causing the CI to fail here, I've created #207 to fix this. |
jonkoops
force-pushed
the
prebuild-copy-package
branch
from
c56b6fa to
72f1e27
Compare
jonkoops
force-pushed
the
prebuild-copy-package
branch
from
72f1e27 to
edca8fc
Compare
frederikprijck
approved these changes
Sep 5, 2023
frederikprijck
added a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Frederik Prijck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
prebuildscript so that it creates thepackage.jsonneeded to properly support CommonJS modules in thebuilddirectory. Before this file would be created after the build finishes, but in some conditions such as running the build in watch mode this file would never be written (see #195 (comment)).This also replaces
rimrafwithshx, which allows us to run Unix commands in a cross-platform manner.