Various review feedback for ESLint configuration #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
commented
Aug 27, 2023
jonkoops
commented
Aug 27, 2023
jonkoops
commented
Aug 27, 2023
jonkoops
commented
Aug 27, 2023
jonkoops
commented
Aug 27, 2023
jonkoops
commented
Aug 27, 2023
jonkoops
force-pushed
the
eslint-feedback
branch
from
e3534fc to
f30e5d2
Compare
jonkoops
commented
Aug 27, 2023
.prettierrc
Outdated
There was a problem hiding this comment.
I've removed the Prettier config, since the default should be good enough. This leads to some code formatting changes, but nothing significant. Also the singleQuote option seems to have no impact anyways, presumably as this is already overwritten at the ESLint level.
There was a problem hiding this comment.
Let's not use 80 chars for printwidth and set it back to 100.
There was a problem hiding this comment.
Sure, added a commit to restore this.
jonkoops
commented
Aug 27, 2023
frederikprijck
approved these changes
Aug 28, 2023
frederikprijck
added a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Frederik Prijck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some changes for the ESLint configuration based on what my review for #200 would have been.