Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Circle Ship Orb configuration #616

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Update Circle Ship Orb configuration #616

merged 7 commits into from
Oct 11, 2022

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 10, 2022 •
edited
Loading

This PR ensures the ship orb configuration is set correctly:

  • Use signingKey instead of SIGNING_KEY
  • Use signingPassword instead of SIGNING_PASSWORD
  • UseskipAssertSigningConfiguration as we are not relying on the OSS-Gradle plugin anymore for the signing, so it can skip its configuration assertion.

@frederikprijck frederikprijck changed the title Update config.yml Update Circle Ship Orb configuration Oct 11, 2022
@frederikprijck frederikprijck marked this pull request as ready for review October 11, 2022 13:18
@frederikprijck frederikprijck requested a review from a team as a code owner October 11, 2022 13:18
jimmyjames
jimmyjames approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jimmyjames jimmyjames merged commit 83eeb3b into master Oct 11, 2022
@jimmyjames jimmyjames deleted the automated-release branch October 11, 2022 14:37
@jimmyjames jimmyjames mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @jimmyjames