Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3226] Expose claim name and header constants #574

Merged
merged 3 commits into from
Apr 13, 2022
Merged

[SDK-3226] Expose claim name and header constants #574

merged 3 commits into from
Apr 13, 2022

Conversation

jimmyjames
Copy link
Contributor

Removes the PublicClaims interface that held constants for claim and header names. Replaces with new StandardClaims and HeaderParams classes to hold these constant values, and are now exported as part of the public API.

@jimmyjames jimmyjames added CH: Added medium This PR may require moderate effort to action, or contains many changes to review labels Apr 12, 2022
@jimmyjames jimmyjames added this to the v4-Beta milestone Apr 12, 2022
@jimmyjames jimmyjames requested a review from a team as a code owner April 12, 2022 23:50
@jimmyjames jimmyjames force-pushed the expose-claim-header-constants branch from 92f7aa6 to 05c925e Compare April 13, 2022 14:58
@jimmyjames jimmyjames closed this Apr 13, 2022
@jimmyjames jimmyjames reopened this Apr 13, 2022
poovamraj
poovamraj approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jimmyjames jimmyjames merged commit c82c150 into v4-dev Apr 13, 2022
@jimmyjames jimmyjames changed the title [SDK-3226] Expose claim header constants [SDK-3226] Expose claim name and header constants Apr 14, 2022
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
@poovamraj poovamraj mentioned this pull request May 6, 2022
Merged
@jimmyjames jimmyjames deleted the expose-claim-header-constants branch October 15, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poovamraj poovamraj poovamraj approved these changes

Assignees
No one assigned
Labels
CH: Added medium This PR may require moderate effort to action, or contains many changes to review
Projects
None yet
Milestone
4.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @poovamraj